[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] ios: open files in binary mode on windows
|
From: |
Jose E. Marchesi |
|
Subject: |
Re: [PATCH] ios: open files in binary mode on windows |
|
Date: |
Tue, 20 Feb 2024 20:37:13 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) |
> Am Dienstag, 20. Februar 2024 um 20:28:52 MEZ hat Jose E. Marchesi
> <jemarch@gnu.org> Folgendes geschrieben:
>
>> Hi Hannes.
>> Isn't this something to do only ifdef _WIN32?
>
> That's what this part is for:
>
>> @@ -32,6 +32,10 @@
>> #include "ios.h"
>> #include "ios-dev.h"
>>
>> +#ifndef O_BINARY
>> +#define O_BINARY 0
>> +#endif
>> +
>> /* State associated with a file device. */
>>
>> struct ios_dev_file
>
>
> But if you don't like it this way, I can change it.
I would prefer a per-target explicit guard, along with a comment
explaining the O_BINARY or-ing trick...