Re: GNU poke 3.90.0 on OpenBSD

[Jose E. Marchesi]

Hi Bruno.

Thanks for the report and patch.
I just installed it in both maint/poke-4 and master.


> On OpenBSD 7.4/x86_64 "make check gives two errors:
>
> ================================================================================
> Making a new site.exp file ...
> WARNING: Couldn't find the global config file.
> Test Run By bruno on Mon Jan 22 15:08:52 2024
> Native configuration is x86_64-unknown-openbsd7.4
>
>               === poke tests ===
>
> Schedule of variations:
>     unix
>
> Running target unix
> Using /usr/local/share/dejagnu/baseboards/unix.exp as board description file 
> for target.
> Using /usr/local/share/dejagnu/config/unix.exp as generic interface file for 
> target.
> Using /home/bruno/poke-3.90.0/testsuite/config/unix.exp as 
> tool-and-target-specific interface file.
> Running /home/bruno/poke-3.90.0/testsuite/poke.cmd/cmd.exp ...
> Running /home/bruno/poke-3.90.0/testsuite/poke.libpoke/libpoke.exp ...
> Running /home/bruno/poke-3.90.0/testsuite/poke.map/map.exp ...
> Running /home/bruno/poke-3.90.0/testsuite/poke.pickles/pickles.exp ...
> Running /home/bruno/poke-3.90.0/testsuite/poke.pkl/pkl.exp ...
> Running /home/bruno/poke-3.90.0/testsuite/poke.pktest/pktest.exp ...
> Running /home/bruno/poke-3.90.0/testsuite/poke.pokefmt/pokefmt.exp ...
> Running /home/bruno/poke-3.90.0/testsuite/poke.repl/repl.exp ...
> ERROR: tcl error sourcing 
> /home/bruno/poke-3.90.0/testsuite/poke.repl/repl.exp.
> ERROR: send: spawn id exp19 not open
>     while executing
> "send "\n" "
>     (procedure "poke_exit" line 7)
>     invoked from within
> "poke_exit"
>     (file "/home/bruno/poke-3.90.0/testsuite/poke.repl/repl.exp" line 99)
>     invoked from within
> "source /home/bruno/poke-3.90.0/testsuite/poke.repl/repl.exp"
>     ("uplevel" body line 1)
>     invoked from within
> "uplevel #0 source /home/bruno/poke-3.90.0/testsuite/poke.repl/repl.exp"
>     invoked from within
> "catch "uplevel #0 source $test_file_name""
> Running /home/bruno/poke-3.90.0/testsuite/poke.std/std.exp ...
> Running /home/bruno/poke-3.90.0/testsuite/poke.time/time.exp ...
> send: spawn id exp19 not open
>     while executing
> "send "\n" "
>     (procedure "poke_exit" line 7)
>     invoked from within
> "${tool}_exit"
>     (procedure "cleanup_target_hook" line 10)
>     invoked from within
> "cleanup_target_hook $current_target"
>     ("foreach" body line 281)
>     invoked from within
> "foreach current_target $target_list {
>     verbose "target is $current_target"
>     set current_target_name $current_target
>     set tlist [split $curren..."
>     (file "/usr/local/share/dejagnu/runtest.exp" line 1630)
> gmake[4]: *** [Makefile:5897: check-DEJAGNU] Error 1
> gmake[4]: Leaving directory '/home/bruno/poke-3.90.0/build/testsuite'
> ================================================================================
>
> At the same time, I'm seeing a core file at testsuite/poke.core.
>
> Running
> $ ./run gdb poke/.libs/poke testsuite/poke.core
> gdb shows me the line poke/pk-repl.c:259
>           rl_line_buffer[rl_point = rl_end = rl_mark = 0] = 0;
> and rl_line_buffer is NULL (if I can trust gdb here).
>
> The attached patch fixes the problems (both the core dump and the "make check"
> failure).