poke-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [COMMITTED] pkl: add assertion to `pvm_make_array_type'


From: Mohammad-Reza Nabipoor
Subject: Re: [COMMITTED] pkl: add assertion to `pvm_make_array_type'
Date: Fri, 28 Oct 2022 08:18:46 +0200

Hi Jose.

On Fri, Oct 28, 2022 at 01:14:46AM +0200, Jose E. Marchesi wrote:
> 
> Hi Mohammad.
> 
> > diff --git a/libpoke/pvm-val.c b/libpoke/pvm-val.c
> > index 641fbd8b..54341761 100644
> > --- a/libpoke/pvm-val.c
> > +++ b/libpoke/pvm-val.c
> > @@ -527,12 +527,14 @@ pvm_make_offset_type (pvm_val base_type, pvm_val unit)
> >  }
> >  
> >  pvm_val
> > -pvm_make_array_type (pvm_val type, pvm_val bound)
> > +pvm_make_array_type (pvm_val type, pvm_val bounder)
> >  {
> >    pvm_val atype = pvm_make_type (PVM_TYPE_ARRAY);
> >  
> > +  assert (bounder);
> 
> I think this ought to be:
> 
>   assert (bounder != PVM_NULL);
> 

Oops!
Sorry!

And fixing it leads to a bunch of failure in `poke.pickles' and
`poke.std' directory!



reply via email to

[Prev in Thread] Current Thread [Next in Thread]