poke-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] pkl: fix mktya doc and usage


From: Mohammad-Reza Nabipoor
Subject: Re: [PATCH 2/2] pkl: fix mktya doc and usage
Date: Thu, 27 Oct 2022 23:07:53 +0200

Hi Jose.

On Thu, Oct 27, 2022 at 10:47:26PM +0200, Jose E. Marchesi wrote:
> 
> Very nice patch, thanks.

Thank you :)

> 
> > +/* Closures which are useful for creating array bounders.  */
> > +
> > +type _Pkl_ClsN = () any;
> > +type _Pkl_ClsI = () uint<64>;
> > +type _Pkl_ClsO = () offset<uint<64>,1>;
> 
> We are generally using the convention to denote function types without
> leaving a space between the argument types and the return type, like
> this:
> 
>  type _Pkl_ClsN = ()any;
>  type _Pkl_ClsI = ()uint<64>;
>  type _Pkl_ClsO = ()offset<uint<64>,1>;
> 
> Given that, OK for master.

Fixed and pushed.
Thanks!



reply via email to

[Prev in Thread] Current Thread [Next in Thread]