[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] pkl-ast: Avoid double-frees by keeping track of frees
|
From: |
Jose E. Marchesi |
|
Subject: |
Re: [PATCH v2] pkl-ast: Avoid double-frees by keeping track of frees |
|
Date: |
Thu, 27 Oct 2022 19:43:22 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
> On Thursday, 27 October 2022 18:12:45 CEST Jose E. Marchesi wrote:
>> We follow the convention to use upper case for macro names, in the
>> codebase.
>>
>
>> I would not define/use PKL_AST_NODE_FREE outside of
>> pkl_ast_node_free_1. It is more clear to call it explicitly from
>> pkl_ast_node_free, where the visitations (cracks me up every time
>> :'D) actually come from.
>
> OK, will change these and push.
Thank you.