poke-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] pk-repl: inform the inputrc parser of the program name


From: Jose E. Marchesi
Subject: Re: [PATCH] pk-repl: inform the inputrc parser of the program name
Date: Tue, 18 Oct 2022 19:08:58 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux)

Hi Arsen.

Thanks for the patch.

> diff --git a/poke/pk-repl.c b/poke/pk-repl.c
> index 351a04ac..31feb4a7 100644
> --- a/poke/pk-repl.c
> +++ b/poke/pk-repl.c
> @@ -329,6 +329,9 @@ pk_repl (void)
>    rl_completer_quote_characters = "\"";
>    rl_completer_word_break_characters = " \t\n\"\\`@$><=;|&{("; /* }) */
>  
> +  /* Let the inputrc parser know who we are.  */
> +  rl_readline_name = "Poke";
> +

If a suitable libreadline is not found by configure, then a replacement
dummy version of the library from gnulib is used.  We need to make sure
that the `readline' gnulib module actually provides rl_readline_name.

A way to test it is to rename libreadline.so in your system or otherwise
make it unavailable in some other way.  Then re-run configure and see
what happens...

I think the application name should be either "poke" or "gnupoke".  Poke
with big-p is the name of the language :)

>    /* Arrange for the current line to be cancelled on SIGINT.
>       Since some library code is also interested in SIGINT
>       (GNU libtextstyle, via gnulib module fatal-signal), it is better



reply via email to

[Prev in Thread] Current Thread [Next in Thread]