Re: doc: Don't leave a broken .texi file around

[Jose E. Marchesi]

Hi Bruno.

Thank you for the patch.
OK for both master and maint/poke-2.


> When building with CFLAGS="-O0 -ggdb", I got a non-functional 'poke' 
> executable,
> and, as a result, the file doc/poke-settings.texi was created, as a 1-line 
> file
> with the contents
>
>   FATAL ERROR: buffer overflow in writing executable code: crash now, in case 
> we have not crashed already
>
> Even after fixing the mistake, that broken .texi file was still there.
>
> This proposed patch fixes it, by touching the .texi file only when the command
> succeeded.
>
>>From 40d06e6b183e1dee20352d973b7c0598b177c02f Mon Sep 17 00:00:00 2001
> From: Bruno Haible <bruno@clisp.org>
> Date: Sun, 30 Jan 2022 23:22:17 +0100
> Subject: [PATCH] doc: Don't leave a broken .texi file around.
>
> * doc/Makefile.am (poke-settings.texi): Don't create poke-settings.texi
> if the command to create it failed.
> (MOSTLYCLEANFILES): Update.
> ---
>  ChangeLog       | 7 +++++++
>  doc/Makefile.am | 4 +++-
>  2 files changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/ChangeLog b/ChangeLog
> index 62145311..6df2d05f 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,10 @@
> +2022-01-30  Bruno Haible  <bruno@clisp.org>
> +
> +     doc: Don't leave a broken .texi file around.
> +     * doc/Makefile.am (poke-settings.texi): Don't create poke-settings.texi
> +     if the command to create it failed.
> +     (MOSTLYCLEANFILES): Update.
> +
>  2022-01-30  Sergio Durigan Junior  <sergiodj@sergiodj.net>
>  
>       * poke/Makefile.am (dist_pkgdata_DATA): Always install
> diff --git a/doc/Makefile.am b/doc/Makefile.am
> index e6b87a64..3bcf5357 100644
> --- a/doc/Makefile.am
> +++ b/doc/Makefile.am
> @@ -32,7 +32,8 @@ pvm-insns.texi: $(top_srcdir)/libpoke/pvm.jitter 
> $(srcdir)/gen-pvm-insns.sh
>  
>  poke-settings.texi: $(srcdir)/poke2texi.pk $(top_srcdir)/poke/pk-settings.pk
>       $(top_builddir)/run poke -L $(srcdir)/poke2texi.pk --settings \
> -          > poke-settings.texi
> +       > poke-settings.texi-tmp
> +     mv poke-settings.texi-tmp poke-settings.texi
>  
>  # This rule generates a list of the node names from the manual.
>  # It then substitutes spaces with '/' which is a kludge used to
> @@ -81,5 +82,6 @@ poke.text: $(srcdir)/poke.texi
>  
>  MOSTLYCLEANFILES = \
>    nodelist \
> +  poke-settings.texi-tmp \
>    poke.txmp
>  MAINTAINERCLEANFILES = pvm-insns.texi poke-settings.texi poke.text