[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: fix a small memory leak
From: |
Jose E. Marchesi |
Subject: |
Re: fix a small memory leak |
Date: |
Sun, 28 Jun 2020 17:22:17 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) |
> Yeah I agree regarding continue vs. if.
You shouldn't have said this :-) Because now I'm proposing a patch that
eliminates most 'continue;' statements.
Heh, I don't regret! :D
The maintainability benefit is that when in the future a developer wants
to insert additional code near the end of a loop, they need to ask
themselves
"inside or outside the 'if' block?" Thus a decision where to put code
becomes
explicit. With 'continue', the programmer is often not aware that they have
a choice.
Yep, although I still think that `continue' has its role, especially in
very long loops, where they appear at the very beginning of the loop.
The Poke for-in loop has an optional `where' clause on this spirit, that
can be used to skip certain elements on the container that guides the
iteration.
The patch is OK for master.
Thanks!