pan-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Pan-devel] Ping khaley, commit 9924d08ef, missed subject_to_path update


From: Duncan
Subject: [Pan-devel] Ping khaley, commit 9924d08ef, missed subject_to_path updates in text_massager_test.cc after updating the header in text_massager.h
Date: Tue, 8 Feb 2011 17:02:45 +0000 (UTC)
User-agent: Pan/0.133 (House of Butterflies; GIT 25ed40d branch-testing)

I just tried updating pan from your testing branch, and ran into a bunch 
of this while building:

[snip]

make[3]: Entering directory `/tmp/portage/net-nntp/pan-9999/work/pan-9999/
pan/usenet-utils'

[snip]

text-massager-test.cc: In function 'int main()':
text-massager-test.cc:274:39: error: too few arguments to function 
'std::string pan::subject_to_path(const char*, bool, const std::string&)'
text-massager.h:63:16: note: declared here
text-massager-test.cc:279:39: error: too few arguments to function 
'std::string pan::subject_to_path(const char*, bool, const std::string&)'

[many further instances of the same error, all or mostly in
text-massager-test.cc]

As I only updated from 25ed40d to b4e791e and the other commits didn't 
touch the affected files, the commit in question appears to be:

commit 9924d08ef9546ae04e538d44575cfe0cb19322ff
Author: K. Haley <address@hidden>
Date:   Mon Dec 13 15:00:28 2010 -0700

    Add options to use full subject line for saving.

Specifically, this change to text-massager.h, with no accompanying change 
to the subject_to_path calls in text-massager-test.cc, only in
text-massager.cc.  WATCH THE MUNGED WRAP!!

--- a/pan/usenet-utils/text-massager.h
+++ b/pan/usenet-utils/text-massager.h
@@ -60,7 +60,7 @@ namespace pan
    *
    * @ingroup usenet_utils
    */
-   std::string subject_to_path (const char * subjectline, const 
std::string &seperator);
+   std::string subject_to_path (const char * subjectline, bool full_subj, 
const std::string &seperator);

 }


-- 
Duncan - List replies preferred.   No HTML msgs.
"Every nonfree program has a lord, a master --
and if you use the program, he is your master."  Richard Stallman




reply via email to

[Prev in Thread] Current Thread [Next in Thread]