Re: [Pan-devel] g_message function calls

[Guilhem Bonnefille]

Hi,

On 1/2/07, Darren Albers <address@hidden> wrote:
> Guilhem Bonnefille wrote:
> > I attached a patch to #372013 (
> > http://bugzilla.gnome.org/show_bug.cgi?id=372013 ).
> >
> > This patch make the logger thread safe. It also replace all g_message
> > calls by a log. So, no more message on the console.
>
> Guilhem, excuse my ignorance but this only applies to connection errors
> right?   I missed a lot of the background on this discussion so what
> issue does this resolve?

Connection errors are the only one reported via g_message calls. So,
they are not reported on the "Log view" dialog and "polute" the
console. The main reason of this is that the connection is threaded
and the logger was not thread safe.

With this patch, I tried to solved both:
- logger is thread safe now,
- connection errors are logged.

But I'm not sure about the way to protect the logger. This is my first
GLib thread and GTK hack. Perhaps someone with better skill can check
it.
--
Guilhem BONNEFILLE
-=- #UIN: 15146515 JID: address@hidden MSN: address@hidden
-=- mailto:address@hidden
-=- http://nathguil.free.fr/