Re: [Pan-devel] Another big Pan code commit

[Christophe Lambin]

On Wed, 09 Mar, 2005 at 22:05 +0100, Charles Kerr wrote:
> I've committed a big set of changes to attack bug #132477, excessive 
> memory usage in large newgroups.

Had some trouble compiling this on FC3: g_fopen, g_mkdir and g_unlink
were only added in glib 2.6. FC3 is still on 2.4.8: 
http://developer.gnome.org/doc/API/2.0/glib/glib-File-Utilities.html#id2967507

Committed a quick path to CVS:

Index: pan/base/pan-glib-extensions.h
===================================================================
RCS file: /cvs/gnome/pan/pan/base/pan-glib-extensions.h,v
retrieving revision 1.32
diff -u -r1.32 pan-glib-extensions.h
--- pan/base/pan-glib-extensions.h      9 Mar 2005 20:15:58 -0000       1.32
+++ pan/base/pan-glib-extensions.h      9 Mar 2005 22:22:49 -0000
@@ -118,7 +118,7 @@
 
 void pan_g_string_strstrip (GString    * str);
 
-#if GLIB_CHECK_VERSION(2,4,0)
+#if GLIB_CHECK_VERSION(2,6,0)
 #define pan_unlink g_unlink
 #define pan_fopen g_fopen
 #else
Index: pan/base/util-file.c
===================================================================
RCS file: /cvs/gnome/pan/pan/base/util-file.c,v
retrieving revision 1.51
diff -u -r1.51 util-file.c
--- pan/base/util-file.c        9 Mar 2005 20:15:58 -0000       1.51
+++ pan/base/util-file.c        9 Mar 2005 22:22:49 -0000
@@ -256,7 +256,7 @@
        else
        {
                errno = 0;
-#if GLIB_CHECK_VERSION(2,4,0)
+#if GLIB_CHECK_VERSION(2,6,0)
                retval = g_mkdir (path, mode);
 #elif defined(G_OS_WIN32)
                retval = mkdir (path);


Regards,
Christophe

pgpoiu131s1wX.pgp
Description: PGP signature