Bug#1023038: oath-toolkit: FTBFS with xmlsec1 1.2.35

[Rene Engelhard]

Source: oath-toolkit
Version: 2.6.7-3
Severity: important

Dear Maintainer,

Hi,

Given I was already a bit wary about the changed in xmlsec1 I uploaded
it to experimental first.
Which turns out to be a good idea since that one causes oath-toolkit to
FTBFS/fail its tests:

make  check-TESTS
make[6]: Entering directory 
'/home/rene/t/oath-toolkit-2.6.7/build/pskctool/tests'
make[7]: Entering directory 
'/home/rene/t/oath-toolkit-2.6.7/build/pskctool/tests'
PASS: tst_hyphen.sh
PASS: tst_roundtrip.sh
FAIL: tst_sign.sh
FAIL: tst_libexamples.sh
PASS: tst_pskctool.sh
==========================================
   pskctool 2.6.7: tests/test-suite.log
==========================================

# TOTAL: 5
# PASS:  3
# SKIP:  0
# XFAIL: 0
# FAIL:  2
# XPASS: 0
# ERROR: 0

.. contents:: :depth: 2

FAIL: tst_libexamples.sh
========================

--- ../../../pskctool/tests/../../libpskc/examples/pskc-hotp-signed.xml 
2020-11-11 18:39:10.000000000 +0000
+++ foo 2022-10-29 14:08:07.929083657 +0000
@@ -38,7 +38,8 @@
 rMxnil6ChoIBvSSPGHhJuj1bW1EPW92JtIa6byrAj1m4RwSviQy2i65YoIdtrhRt
 CWekj2zuL/0szv5rZMCCvxioOCA8znqELEPMfs0Aa/cACD2MZcC4gGXehNCvzYJr
 TmB6lFpxP6f0g6eO7PVcqYN9NCwECxb5Cvx2j2uNlereY35/9oPR6YJx+V7sL+DB
-n6F0mN8OUAFxDamepKdGRApU8uZ35624o/I4</X509Certificate>
+n6F0mN8OUAFxDamepKdGRApU8uZ35624o/I4
+</X509Certificate>
 </X509Data>
 </KeyInfo>
 </Signature></KeyContainer>
FAIL: pskctool --sign output change, commit updated file.
FAIL tst_libexamples.sh (exit status: 1)

FAIL: tst_sign.sh
=================

--- ../../../pskctool/tests/pskc-all-signed.xml 2021-04-30 19:24:55.000000000 
+0000
+++ tmp-signed.xml      2022-10-29 14:08:07.909083495 +0000
@@ -38,7 +38,8 @@
 rMxnil6ChoIBvSSPGHhJuj1bW1EPW92JtIa6byrAj1m4RwSviQy2i65YoIdtrhRt
 CWekj2zuL/0szv5rZMCCvxioOCA8znqELEPMfs0Aa/cACD2MZcC4gGXehNCvzYJr
 TmB6lFpxP6f0g6eO7PVcqYN9NCwECxb5Cvx2j2uNlereY35/9oPR6YJx+V7sL+DB
-n6F0mN8OUAFxDamepKdGRApU8uZ35624o/I4</X509Certificate>
+n6F0mN8OUAFxDamepKdGRApU8uZ35624o/I4
+</X509Certificate>
 </X509Data>
 </KeyInfo>
 </Signature></KeyContainer>
FAIL tst_sign.sh (exit status: 1)

============================================================================
Testsuite summary for pskctool 2.6.7
============================================================================
 TOTAL: 5
# PASS:  3
# SKIP:  0
# XFAIL: 0
# FAIL:  2
# XPASS: 0
# ERROR: 0
============================================================================
See tests/test-suite.log
Please report to oath-toolkit-help@nongnu.org
============================================================================
make[7]: *** [Makefile:1640: test-suite.log] Error 1
make[7]: Leaving directory 
'/home/rene/t/oath-toolkit-2.6.7/build/pskctool/tests'
make[6]: *** [Makefile:1748: check-TESTS] Error 2
make[6]: Leaving directory 
'/home/rene/t/oath-toolkit-2.6.7/build/pskctool/tests'
make[5]: *** [Makefile:1849: check-am] Error 2
make[5]: Leaving directory 
'/home/rene/t/oath-toolkit-2.6.7/build/pskctool/tests'
make[4]: *** [Makefile:1757: check-recursive] Error 1
make[4]: Leaving directory '/home/rene/t/oath-toolkit-2.6.7/build/pskctool'
make[3]: *** [Makefile:2054: check] Error 2
make[3]: Leaving directory '/home/rene/t/oath-toolkit-2.6.7/build/pskctool'
make[2]: *** [Makefile:406: check-recursive] Error 1
make[2]: Leaving directory '/home/rene/t/oath-toolkit-2.6.7/build'
make[1]: *** [Makefile:706: check] Error 2
make[1]: Leaving directory '/home/rene/t/oath-toolkit-2.6.7/build'
dh_auto_test: error: cd build && make -j16 check "TESTSUITEFLAGS=-j16 
--verbose" VERBOSE=1 returned exit code 2
make: *** [debian/rules:8: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2

So basically the reference file needs to be updated but then it probably
breaks with 1.2.34...

Regards,

Rene