[Mldonkey-tasks] [task #5904] shell:// type url for rss feeds

[jave]

URL:
  <http://savannah.nongnu.org/task/?5904>

                 Summary: shell:// type url for rss feeds
                 Project: mldonkey, a multi-networks file-sharing client
            Submitted by: jave
            Submitted on: Thursday 09/14/2006 at 21:43
                Category: None
                Priority: 1 - Later
                  Status: None
             Assigned to: None
             Open/Closed: Open
         Should Start On: Thursday 09/14/2006 at 00:00
   Should be Finished on: Thursday 09/14/2006 at 00:00

    _______________________________________________________

Details:

Ive made a small patch for rss feeds, so shell:// style urls can be used.

I wanted this so I could get broken rss feeds, and fix them up with xmllint
first.

There are of course pros and cons to this.
Pro: 
- mldonkey dont need to deal with each and every brokeness out there. feed
them first through xmllint or whatever
- rss feeds can be synthesized from web pages( i have a couple of these
already)

Con:
- maybe opens new security holes

The cons could be handled the same way as for the "!" command(my patch
currently doesnt). Pango has a pach for a security enhanced "!" command,
which could be refactored to be used with this shell:// extension. The idea
is that this extension wont cause more trouble than the existing "!" command,
if done properly.

here is what the patch looks like:

in commonweb:

rename mldonkey_wget to mldonkey_wget_url

let mldonkey_wget_shell url f =                                              
                                                                              
                                                                              
                                        
  let command_urlencoded = Str.string_after url 8 in                         
                                                                              
                                                                              
                                        
  let command = Url.decode command_urlencoded in                             
                                                                              
                                                                              
                                        
  let filename = "/tmp/crapname.out" in                                      
                                                                              
                                                                              
                                        
    Sys.command (Printf.sprintf "%s > %s" command filename);                 
                                                                              
                                                                              
                                        
    (f filename : unit)                                                      
                                                                              
                                                                              
                                        
      (* wget does something like this at the end: (f filename : unit); *)   
                                                                              
                                                                              
                                        
                                                                             
                                                                              
                                                                              
                                        
                                                                             
                                                                              
                                                                              
                                        
let mldonkey_wget url f =                                                    
                                                                              
                                                                              
                                        
  if Str.string_match (Str.regexp "shell://") url 0 then                     
                                                                              
                                                                              
                                        
    mldonkey_wget_shell url f                                                
                                                                              
                                                                              
                                        
  else                                                                       
                                                                              
                                                                              
                                        
    mldonkey_wget_url url f 


a testcase:
urladd rss
shell:///tmp/rsscommand%2520http%253A//thepiratebay.org/rss.php%253Fcat%253D601

where rsscommand looks like:

curl $1|xmllint - 







    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/task/?5904>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/