Re: [Maposmatic-dev] [PATCH] Adding links from jobs to OpenStreetMap main site

[Maxime Petazzoni]

Hi Pierre,

This is a lot better. I have one last remark though, see below.

* Pierre Mauduit <address@hidden> [2010-08-04 19:40:48]:

> +  {% if job.administrative_city %}
> +    <a href="http://www.osm.org?relation={{ job.administrative_osmid|abs 
> }}">{% trans "View on OpenStreetMap" %}</a>
> +  {% else %}
> +    <a href="http://www.osm.org?maxlat={{ job.lat_upper_left 
> }}&amp;maxlon={{ job.lon_bottom_right }}&amp;minlat={{ job.lat_bottom_right  
> }}&amp;minlon={{ job.lon_upper_left  }}">{% trans "View on OpenStreetMap" 
> %}</a>
> +  {% endif %}

This would be better as:

  <a href="http://osm.org/?{% if job.administrative_city %}relation={{ 
job.administrative_osmid|abs }}{% else %}maxlat=...{% endif %}">{% trans "View 
on OpenStreetMap" %}</a>

Thanks !

- Maxime
-- 
Maxime Petazzoni <http://www.bulix.org>
 ``One by one, the penguins took away my sanity.''
Linux kernel and software developer at MontaVista Software

signature.asc
Description: Digital signature