Re: command line limit in mingw-make

[Jonathan Liu]

On 26/05/2012 4:05 AM, Eli Zaretskii wrote:
> > Date: Fri, 25 May 2012 17:04:12 +0100
> > From: Joe Burmeister<address@hidden>
> > CC: address@hidden
> >
> > > >     From what you just told me, I don't see why this would trigger a
> > > > intermediate batch file like this.
> > > I'm guessing those are the quotes.
> > that will be why it's pretty much everything. No doubt they are added
> > for spaces safety.
> >
> > A quick test with CreateProcess seams to show it's not necessary for
> > this to trigger an intermediate batch file.
>
> Probably.  Can you try building make.exe with MinGW, after removing
> the " character from sh_chars_dos[] defined on job.c under WINDOWS32?
>
> (Building a MinGW Make requires to run the build_w32.bat batch file;
> see the file README.W32 for instructions.)

I have removed the " character from sh_chars_dos and it works.
I can now build qt5 qtwebkit which has really long command lines (around 
12000 characters long). Also, quoted filenames that have spaces still 
work fine in Makefiles.

Could this be change applied to CVS?

Regards,
Jonathan