make-w32
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Make on XP - shell selection?


From: Eli Zaretskii
Subject: Re: Make on XP - shell selection?
Date: Mon, 22 Oct 2007 22:54:27 +0200

> Date: Mon, 22 Oct 2007 12:56:21 +0800
> From: "Yongwei Wu" <address@hidden>
> Cc: "Eli Zaretskii" <address@hidden>, address@hidden
> 
> On 21/10/2007, grischka <address@hidden> wrote:
> > We can initialize SHELL either fixed to COMSPEC, or fixed to "sh",
> > optionally from the environment (SHELL or MAKESHELL), or based on PATH
> > search as currently (which I think is evil, though).
> >
> > As 'default shell' on windows is a political question, I can only
> > vote. I think a good compromise is COMSPEC as default, and MAKESHELL
> > from the environment if set. It means dependency on environment too,
> > but at least if you set it you know you have set it, and it does not
> > change if you change PATH. So there is less surprise.
> 
> I like this idea: mysteriously changing the behaviour of a Makefile
> because of a sh.exe somewhere in the path was a surprise to me.  If
> one does want sh, set SHELL or MAKESHELL.  If neither of them is
> present, COMSPEC is a good guess.

Sorry, guys, I'm not going to change behavior that was introduced 5
years ago, just because it doesn't TRT in some marginal cases.  Such a
change runs a risk of breaking many more Makefiles for many more
users.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]