Re: Make CVS HEAD version build out of the box

[Yongwei Wu]

On 02/10/2007, Eli Zaretskii <address@hidden> wrote:
> > Date: Tue, 2 Oct 2007 20:16:36 +0800
> > From: "Yongwei Wu" <address@hidden>
> > Cc: "Eli Zaretskii" <address@hidden>, address@hidden
> >
> > +#! /bin/sh
> > +VERSION=`sed -n 's/^AC_INIT(\[GNU make\],\[\([^]]\+\)\].*/\1/p' 
> > configure.in`
> > +sed -e "s/%PACKAGE%/make/" -e "s/%VERSION%/$VERSION/"
> > config.h.W32.template > config.h.W32
>
> Thanks.
>
> Personally, I think that requiring a Unixy shell for such a simple job
> is an overkill.
>
> How about the following alternative?
>
> --- build_w32.bat~0     2007-07-21 19:01:24.376125000 +0300
> +++ build_w32.bat       2007-10-02 17:40:25.453125000 +0200
> @@ -16,6 +16,11 @@
>  rem You should have received a copy of the GNU General Public License along
>  rem with this program.  If not, see <http://www.gnu.org/licenses/>.
>
> +if exist config.h.W32 GoTo NotCVS
> +sed -n "s/^AC_INIT(\[GNU make\],\[\([^]]\+\)\].*/s,%%VERSION%%,\1,g/p" 
> configure.in > config.h.W32.sed
> +echo s,%%PACKAGE%%,make,g >> config.h.W32.sed
> +sed -f config.h.W32.sed config.h.W32.template > config.h.W32
> +:NotCVS
>  if not exist config.h copy config.h.W32 config.h
>  cd w32\subproc
>  echo "Creating the subproc library"

All are silent?  Could we first do the undisputed patches, like this
one and the w32_kill change?

And I think the CVS version should at least build.  So I think Eli's
patch to change `p[-1] =' is better than the current state, using or
not using alloca. --- What do you think?

Best regards,

Yongwei

-- 
Wu Yongwei
URL: http://wyw.dcweb.cn/