Re: FWD: Make CVS 7X slower on Win32 NTFS than beta 4

[Markus Mauhart]

"Eli Zaretskii" <address@hidden> wrote ...
>
> +   else if (stat(dir->path_key, &st) == 0 && st.st_mtime > dir->mtime)

Just one note:

Function stat(..) is used at two additional places in dir.c, both times
via macro EINTRLOOP, defined in make.h:

  /* Some systems (like Solaris, PTX, etc.) do not support the SA_RESTART flag
     properly according to POSIX.  So, we try to wrap common system calls with
     checks for EINTR.....or you need to avoid -j.
  */
  #define EINTRLOOP(_v,_c)   while (((_v)=_c)==-1 && errno==EINTR)

Hence for consistency I would add a comparable loop here too.


Regards,
Markus.