m4-discuss
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: M4 1.4.10b [beta] released


From: Eric Blake
Subject: Re: M4 1.4.10b [beta] released
Date: Sat, 01 Mar 2008 11:32:39 -0700
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.12) Gecko/20080213 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

According to Jim Meyering on 3/1/2008 11:26 AM:
| +  while (1)
| +    {
| +      size_t len;
| +      const char *buffer = next_buffer (&len, false);
| +      if (buffer)
| +       {
| +         const char *p = (char *) memchr (buffer, '\n', len);
|
| That cast looks unnecessary -- unless you care about C++ compilers.

Yes, at one point, I got M4 to compile with C++; I've tried to keep it
that way (although inadvertent regressions may have crept in since).  In
other words, I deliberately added that cast.  It's a shame that memchr is
prototyped to return void* instead of char*.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHyaFH84KuGfSFAYARAodpAJ9mXz4L5lDGMo1ILxbocZc3zkWTxACbB7hg
8Iyzx6dtqZ+kRyghZ/cbHlI=
=PRNK
-----END PGP SIGNATURE-----




reply via email to

[Prev in Thread] Current Thread [Next in Thread]