[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Lynx-dev] LYMain.c fails to compile if USE_PERSISTENT_COOKIES is un
From: |
Thorsten Glaser |
Subject: |
Re: [Lynx-dev] LYMain.c fails to compile if USE_PERSISTENT_COOKIES is undefined. |
Date: |
Wed, 11 Jul 2018 20:17:43 +0000 (UTC) |
Juan Manuel Guerrero dixit:
> +#ifdef USE_PERSISTENT_COOKIES
> if (LYCookieFile != 0 && LYCookieSaveFile != 0) {
> +#else
> + {
Shouldn’t that be an “if (0) {” instead?
> +#endif
> /* set few safe flags: */
> #ifdef USE_PERSISTENT_COOKIES
> BOOLEAN persistent_cookies_flag = persistent_cookies;
> char *LYCookieFile_flag = NULL;
> char *LYCookieSaveFile_flag = NULL;
Also, consider something like this:
#ifdef USE_PERSISTENT_COOKIES
if (LYCookieFile != 0 && LYCookieSaveFile != 0)
#else
if (0)
#endif
{
…
}
With the { a bit indented from each of the ifs, but less
than the block inside, to make editors’ jump-to-matching-
brace functions not fuck up.
bye,
//mirabilos
--
Sometimes they [people] care too much: pretty printers [and syntax highligh-
ting, d.A.] mechanically produce pretty output that accentuates irrelevant
detail in the program, which is as sensible as putting all the prepositions
in English text in bold font. -- Rob Pike in "Notes on Programming in C"