RE: [Lynx-dev] lynx 2.8.5 crashing on Windows Server 2003

[patakuti]

On Sun, 9 Jul 2006, address@hidden wrote:

> On Sat, 8 Jul 2006, David Potter (Home) wrote:
> 
> > I expected as much :-).  As far as I know I have the latest non-beta
> > version (2.8.5).  I suppose I could try the beta version.
> 
> That sounds like a good idea (there are 2-3 binaries for download which 
> should have 2.8.6dev.something in the version string).

I tested 2.8.6dev.18 on Windows and found it was crashed.
So I checked sources and found a bug in HTTP.c.

   299          } else if (val == WAIT_OBJECT_0) {
   300              if (GetExitCodeThread(hThread, &exitcode) == FALSE) {
   301                  exitcode = -1;
   302              }

If GetExitCodeThread failed, exitcode is set as 0xFFFFFFFF.
# exitcode is DWORD.

   303              if (CloseHandle(hThread) == FALSE) {
   304                  HTInfoMsg("Thread terminate Failed");
   305              }
   306              now_TickCount = GetTickCount();
   307              if (now_TickCount >= save_TickCount)
   308                  process_time = now_TickCount - save_TickCount;
   309              else
   310                  process_time = now_TickCount + (0xffffffff - 
save_TickCount);
   311  
   312              if (process_time == 0)
   313                  process_time = 1;
   314              g_total_times += process_time;
   315              g_total_bytes += exitcode;
   316  
   317              if (g_total_bytes > 2000000) {

The condition must be true because g_total_bytes (=exitcode) is very
big.

   318                  ws_read_per_sec = g_total_bytes / (g_total_times / 
1000);

If g_total_times is less than 1000, then we got div 0 error here.
I tried http://whatismyip.org/ many times and I found that sometimes
GetExitCodeThread failed and g_total_times is less than 1000 and Lynx
is crashed.

> -- 
> Thomas E. Dickey
> http://invisible-island.net
> ftp://invisible-island.net
--
Takeshi Hataguchi
E-mail: address@hidden