Re: [Lynx-dev] 2.8.6dev.10

[Thorsten Glaser]

Thomas Dickey dixit:

>2005-01-02 (2.8.6dev.10)

You rock!

It works, and is now in MirOS CVS -HEAD. All the problems I had with
spurious newlines and stuff are vanished.

There's still one display bug:

- go to http://wiki.mirbsd.de/SomeNotExistingWikiName
- go to the text editing field, activate it
  (I've got textfields need activation on)
- press ^Xe to go to the external editor
  (joe-editor here)
- read in a rather large file (such as this eMail)
  (in jstar: ^Kr)
- exit the editor
  (in jstar: ^Kx)
- scroll down with PgDn

The text input field (without text) and surrounding HTML is
repeated, just not selectable.

If I scroll up (PgUp) then hit the End key, I see nothing.
Then scroll up (PgUp), a bit down (Del), then back down
(PgDn), it re-appears.

No idea what it could be. This was in dev.7b too.


A few nitpicks:

No const because man define_key says (ncurses):

NAME
     define_key - define a keycode

SYNOPSIS
     #include <curses.h>

     int define_key(char *definition, int keycode);


--- LYStrings.c 3 Jan 2005 00:56:45 -0000       1.2
+++ LYStrings.c 3 Jan 2005 01:15:10 -0000
@@ -859,7 +859,7 @@
 #endif
 
 typedef struct {
-    const char *string;
+    char *string;
     int value;
 } Keysym_String_List;
 /* *INDENT-OFF* */


Without comment...

--- HTTelnet.c  3 Jan 2005 00:23:35 -0000       1.1.2.1
+++ HTTelnet.c  3 Jan 2005 01:09:41 -0000
@@ -484,6 +484,8 @@
     }
 #endif /* !TELNET_DONE */
     return HT_NO_DATA;
+    /* shut up gcc */
+    do_system(NULL);
 }
 
 /*     "Load a document" -- establishes a session


Some more warnings.

--- src/LYCgi.c 3 Jan 2005 00:23:42 -0000       1.1.2.1
+++ src/LYCgi.c 3 Jan 2005 00:56:44 -0000       1.2
@@ -1,3 +1,5 @@
+/* $MirBSD: src/gnu/usr.bin/lynx/src/LYCgi.c,v 1.2 2005/01/03 00:56:44 tg Exp 
$ */
+
 /*                   Lynx CGI support                              LYCgi.c
  *                   ================
  *
@@ -149,10 +151,10 @@
     return -1;
 }
 #else
-static int LYLoadCGI(const char *arg,
-                    HTParentAnchor *anAnchor,
-                    HTFormat format_out,
-                    HTStream *sink)
+static int LYLoadCGI(const char *arg GCC_UNUSED,
+                    HTParentAnchor *anAnchor GCC_UNUSED,
+                    HTFormat format_out GCC_UNUSED,
+                    HTStream *sink GCC_UNUSED)
 {
     int status = 0;
 

Move KANJI_CODE_OVERRIDE to a more sensible key.
^L _is_ redraw screen, you know ;)

--- userdefs.h  3 Jan 2005 00:23:34 -0000       1.1.2.1
+++ userdefs.h  3 Jan 2005 00:56:40 -0000       1.2
@@ -1548,11 +1548,11 @@
  
 /***************************** 
  * Uncomment the following line to enable the kanji code override routine. 
- * The code can be changed by pressing ^L.  More precisely, this allows 
+ * The code can be changed by pressing shift-J.  More precisely, this allows
  * the user to override the assumption about the kanji code for the document 
  * which Lynx has made on the basis of a META tag and HTTP response. 
  */ 
-/*#define KANJI_CODE_OVERRIDE */ 
+#define KANJI_CODE_OVERRIDE
  
 
 /****************************************************************

--- src/LYKeymap.c      3 Jan 2005 00:23:43 -0000       1.1.2.1
+++ src/LYKeymap.c      3 Jan 2005 00:56:44 -0000       1.2
@@ -72,14 +72,8 @@
 LYK_HISTORY,    LYK_FASTFORW_LINK,  LYK_ACTIVATE,  LYK_COOKIE_JAR,
 /* bs */            /* ht */        /* nl */       /* ^K */
 
-#ifdef KANJI_CODE_OVERRIDE
-LYK_CHG_KCODE,    LYK_ACTIVATE,     LYK_DOWN_TWO,      0,
-/* ^L */            /* cr */        /* ^N */       /* ^O */
-
-#else
 LYK_REFRESH,      LYK_ACTIVATE,     LYK_DOWN_TWO,      0,
 /* ^L */            /* cr */        /* ^N */       /* ^O */
-#endif
 
 LYK_UP_TWO,       LYK_CHG_CENTER,   LYK_RELOAD,    LYK_TO_CLIPBOARD,
 /* ^P */            /* XON */       /* ^R */       /* ^S */
@@ -128,8 +126,14 @@
 LYK_DOWNLOAD,        LYK_ELGOTO,  LYK_DIRED_MENU,   LYK_ECGOTO,
 /* D */              /* E */         /* F */        /* G */
 
+#ifdef KANJI_CODE_OVERRIDE
+LYK_HELP,            LYK_INDEX,      LYK_CHG_KCODE, LYK_KEYMAP,
+/* H */              /* I */         /* J */        /* K */
+
+#else
 LYK_HELP,            LYK_INDEX,      LYK_JUMP,      LYK_KEYMAP,
 /* H */              /* I */         /* J */        /* K */
+#endif
 
 LYK_LIST,          LYK_MAIN_MENU,    LYK_PREV,      LYK_OPTIONS,
 /* L */              /* M */         /* N */        /* O */


Keep up the good work,
//mirabile