[lwip-devel] [bug #65590] Windows: thread holder reset prematurely, breaking lock checks

[Alexander Festini]

URL:
  <https://savannah.nongnu.org/bugs/?65590>

                 Summary: Windows: thread holder reset prematurely, breaking
lock checks
                   Group: lwIP - A Lightweight TCP/IP stack
               Submitter: afestini
               Submitted: Sun 14 Apr 2024 06:54:06 AM UTC
                Category: Platform ports
                Severity: 3 - Normal
              Item Group: Faulty Behaviour
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None
            lwIP version: git head


    _______________________________________________________

Follow-up Comments:


-------------------------------------------------------
Date: Sun 14 Apr 2024 06:54:06 AM UTC By: Alexander Festini <afestini>
The underlying mutex is recursive and judging from some logging, will have
nested locks in some cases.

Setting the thread holder to 0 on every unlock without checking the number of
lock calls results in incorrect asserts.

The line
lwip_core_lock_holder_thread_id = 0;

should only be executed when the last lock is released, either by keeping a
counter to track locks/unlocks or (if possible) by getting that information
from the mutex itself.







    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/bugs/?65590>

_______________________________________________
Message sent via Savannah
https://savannah.nongnu.org/