[lwip-devel] [patch #10412] freertos port: xSemaphoreTake() should return pdFAIL

[quanjia]

URL:
  <https://savannah.nongnu.org/patch/?10412>

                 Summary: freertos port: xSemaphoreTake() should return pdFAIL
                   Group: lwIP - A Lightweight TCP/IP stack
               Submitter: quanjia
               Submitted: Sat 18 Nov 2023 02:41:31 AM UTC
                Category: Contrib
                Priority: 5 - Normal
                  Status: None
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: None


    _______________________________________________________

Follow-up Comments:


-------------------------------------------------------
Date: Sat 18 Nov 2023 02:41:31 AM UTC By: quanjia <quanjia>
in contrib\ports\freertos\sys_arch.c
sys_arch_sem_wait(sys_sem_t *sem, u32_t timeout_ms)
{
    ...
    ret = xSemaphoreTake(sem->sem, timeout_ticks);
    if (ret == errQUEUE_EMPTY) {
      /* timed out */
      return SYS_ARCH_TIMEOUT;
    }
    ...
}

call xSemaphoreTake() check return value with errQUEUE_EMPTY, but actually,
xSemaphoreTake() returns only pdPASS/pdFAIL.
In fact errQUEUE_EMPTY is 0, pdFAIL is also 0, so that still works, but there
may be some misleading, so I think it's better to fix it.







    _______________________________________________________
File Attachments:


-------------------------------------------------------
Date: Sat 18 Nov 2023 02:41:31 AM UTC  Name:
0001-freertos-port-xSemaphoreTake-should-return-pdFAIL-on.patch  Size: 869B  
By: quanjia

<http://savannah.nongnu.org/patch/download.php?file_id=55337>

    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/patch/?10412>

_______________________________________________
Message sent via Savannah
https://savannah.nongnu.org/