Re: [lwip-devel] [PATCHv4 0/5] net/lwip: add lwip library for the network stack

[Ilias Apalodimas]

Hi Maxim, 

On Fri, Jul 14, 2023 at 08:19:55PM +0600, Maxim Uvarov wrote:
> changelog:
>       v4: - tested with tests/py/ did some minor fixes (out of tree
>               build, variables set after downloads).
>           - accounted review comments for documentation.
>           - implemented dns command
>             - corrected wget command to not use serverip variable and use just
>               url string.
>       v3: - use lwip commands for ping,tftp,wget,dhcp if this patch
>             applied. Drop CONFIG_LIB_LWIP_REPLACE_<COMMAND> option.
>           - docs: use rst variant and drop references to RFC.
> 
> build:
>       git submodule init
>       git submodule update
>       make 
> 
> I tested with qemu and ubuntu host for the server manually and with
> ./test/py/test -bd qemu_arm64 --build -k net.
> 
> Maxim Uvarov (5):
>   net/lwip: add lwip-external submodule
>   net/lwip: add lwip library for the network stack
>   net/lwip: add doc/develop/net_lwip.rst
>   net/lwip: add dns command

This dones't apply to master.  Can you rebase and resend it?

Thanks
/Ilias
>   net/lwip: apps/http: add dns support
> 
>  .gitignore                            |   9 +
>  .gitmodules                           |   3 +
>  boot/bootmeth_pxe.c                   |   2 +-
>  cmd/net.c                             |  89 +-------
>  cmd/pxe.c                             |   2 +-
>  doc/develop/index.rst                 |   1 +
>  doc/develop/net_lwip.rst              |  59 +++++
>  include/net.h                         |   8 +-
>  lib/Kconfig                           |   2 +
>  lib/Makefile                          |   2 +
>  lib/lwip/Kconfig                      |  63 ++++++
>  lib/lwip/Makefile                     | 103 +++++++++
>  lib/lwip/apps/dhcp/lwip-dhcp.c        |  52 +++++
>  lib/lwip/apps/dns/lwip-dns.c          |  46 ++++
>  lib/lwip/apps/dns/lwip-dns.h          |   3 +
>  lib/lwip/apps/http/lwip-wget.c        | 121 ++++++++++
>  lib/lwip/apps/ping/lwip_ping.c        |  37 ++++
>  lib/lwip/apps/ping/lwip_ping.h        |  24 ++
>  lib/lwip/apps/ping/ping.h             |  35 +++
>  lib/lwip/apps/tftp/lwip-tftp.c        | 124 +++++++++++
>  lib/lwip/cmd-lwip.c                   | 308 ++++++++++++++++++++++++++
>  lib/lwip/lwip-external                |   1 +
>  lib/lwip/lwipopts.h                   | 203 +++++++++++++++++
>  lib/lwip/port/if.c                    | 260 ++++++++++++++++++++++
>  lib/lwip/port/include/arch/cc.h       |  46 ++++
>  lib/lwip/port/include/arch/sys_arch.h |  59 +++++
>  lib/lwip/port/include/limits.h        |   0
>  lib/lwip/port/sys-arch.c              |  20 ++
>  lib/lwip/ulwip.h                      |   9 +
>  net/Kconfig                           |   1 +
>  net/net.c                             |  24 ++
>  31 files changed, 1634 insertions(+), 82 deletions(-)
>  create mode 100644 .gitmodules
>  create mode 100644 doc/develop/net_lwip.rst
>  create mode 100644 lib/lwip/Kconfig
>  create mode 100644 lib/lwip/Makefile
>  create mode 100644 lib/lwip/apps/dhcp/lwip-dhcp.c
>  create mode 100644 lib/lwip/apps/dns/lwip-dns.c
>  create mode 100644 lib/lwip/apps/dns/lwip-dns.h
>  create mode 100644 lib/lwip/apps/http/lwip-wget.c
>  create mode 100644 lib/lwip/apps/ping/lwip_ping.c
>  create mode 100644 lib/lwip/apps/ping/lwip_ping.h
>  create mode 100644 lib/lwip/apps/ping/ping.h
>  create mode 100644 lib/lwip/apps/tftp/lwip-tftp.c
>  create mode 100644 lib/lwip/cmd-lwip.c
>  create mode 160000 lib/lwip/lwip-external
>  create mode 100644 lib/lwip/lwipopts.h
>  create mode 100644 lib/lwip/port/if.c
>  create mode 100644 lib/lwip/port/include/arch/cc.h
>  create mode 100644 lib/lwip/port/include/arch/sys_arch.h
>  create mode 100644 lib/lwip/port/include/limits.h
>  create mode 100644 lib/lwip/port/sys-arch.c
>  create mode 100644 lib/lwip/ulwip.h
> 
> -- 
> 2.30.2
>