[lwip-devel] [patch #10194] Make DHCP module more adjustable

[David Cermak]

Follow-up Comment #6, patch #10194 (project lwip):

1) Thanks for suggestion. Have reworked the patch to add this
`dhcp_start_from_reboot()` API.
(the reason for making it so generic was to minimize requested changes,
providing versatility if users wanted to jump to any other state (even
violating the spec), my workaround to access the internals was this macro
magic:
https://github.com/espressif/esp-idf/blob/54576b7528b182256c027de86eb605a172bc2821/components/lwip/port/include/lwipopts.h#L328-L333)

4) Used this MACRO="VALUE" (quoted) notation deliberately in the comments, but
I agree that using #define MACRO VALUE is more descriptive.

> took the liberty to slightly adapt the path while applying, but only in the
example comment.

This comment broke the doxygen. The attached patch fixes the build by
enclosing it within `\code` tags.

2) 3) Thanks for accepting the patches!


(file #54733, file #54734)

    _______________________________________________________

Additional Item Attachment:

File name:
0001-Fix2-dhcp-Add-dhcp_start_from_reboot-API-to-start-DHCP-wi.patch Size:7 KB
   
<https://file.savannah.nongnu.org/file/0001-Fix2-dhcp-Add-dhcp_start_from_reboot-API-to-start-DHCP-wi.patch?file_id=54733>

File name:
0004-Fix2-dhcp-docs-Fix-doxygen-build-to-mark-define-in-commen.patch Size:0 KB
   
<https://file.savannah.nongnu.org/file/0004-Fix2-dhcp-docs-Fix-doxygen-build-to-mark-define-in-commen.patch?file_id=54734>



    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/patch/?10194>

_______________________________________________
Message sent via Savannah
https://savannah.nongnu.org/