[lwip-devel] [patch #10194] Make DHCP module more adjustable

[Simon Goldschmidt]

Follow-up Comment #1, patch #10194 (project lwip):

Let me respond to each patch:

1) Hooks must be documented in opt.h, see LWIP_HOOK_IP4_ROUTE_SRC. Also,
POST_INIT might not be a name that is descriptive enough for what it does
(aborting discover after start?)? Please also describe in which situations
this is used, describe an example.

2) DHCP_DEFINE_CUSTOM_TIMEOUTS is not described anywhere; u16_t/u32_t change
should be a no-op if this feature is not enabled; 'inline' is not portable;
also, maybe the changes from in-place-code to defines calculating the timeouts
could be in a separate commit from adding the custom tmieouts?

3) This should be configurable. Not everyone wants to the hostname to be added
here.

4) This is not a hook. A hook is a function to be called at some point to
change he behaviour. I'd just rename the define. But what we need is an
example of the contents of this define (i.e., in this case, you need the
define to be a comma-separated list starting with a comma; this needs to be
clearly documented!)


    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/patch/?10194>

_______________________________________________
Message sent via Savannah
https://savannah.nongnu.org/