lwip-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lwip-devel] [bug #58473] Trailing dot in hostname results in extraneous


From: Erik Ekman
Subject: [lwip-devel] [bug #58473] Trailing dot in hostname results in extraneous label (and corrupt packet)
Date: Fri, 19 Jun 2020 06:14:47 -0400 (EDT)
User-agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/83.0.4103.97 Safari/537.36

Follow-up Comment #6, bug #58473 (project lwip):

If we just do this change, lookups of the same domain with and without a
trailing dot will not share a hostlist entry but trigger a second lookup as I
understand it. Removing the dot before checking the list of cached entries
seems better to me.

dns_local_lookup already removes an extra dot early:

  hostnamelen = strlen(hostname);
  if (hostname[hostnamelen - 1] == '.') {
    hostnamelen--;
  }

http://git.savannah.nongnu.org/cgit/lwip.git/tree/src/core/dns.c#n486

    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/bugs/?58473>

_______________________________________________
  Message sent via Savannah
  https://savannah.nongnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]