[lwip-devel] [patch #9862] altcp_mbedtls: multiple fixes and session save/restore

[Simon Goldschmidt]

Follow-up Comment #1, patch #9862 (project lwip):

Sorry this took 2 months...

- to 0001: shouldn't this be fixed by altcp_mbedtls_unref_entropy() some lines
below?
- to 0002: including mbedtls headers in the application should be avoided. Up
to now, applications don't need to set an include path that provides mbedtls
headers, and I'd like to keep it that way. Given how much mbedTLS itself uses
malloc, can we solve this without a public include to mbedTLS?
- to 0003: I don't really get the code flow here, could you explain more in
the commit message what's done?
- to 0005: This seems wrong: you can't block interrupts during ref/unref/free
entropy (you'll break realtime behaviour of many systems) and you shouldn't.
All this altcp code is expected to be called under CORE_LOCK, so concurrent
execution is not supported anyway.


    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/patch/?9862>

_______________________________________________
  Message sent via Savannah
  https://savannah.nongnu.org/