[lwip-devel] [patch #9860] mdns: fixes for Bonjour Conformance Tests

[Simon Goldschmidt]

Update of patch #9860 (project lwip):

                  Status:                    None => In Progress            
             Assigned to:                    None => goldsimon              

    _______________________________________________________

Follow-up Comment #1:

Thanks for sharing this! And sorry for taking so long to review.

The patches overall look good, however, some comments:

- some typos in commit messages and comments here and there...

- patch 1 increases memory usage. This should probably be a config option, and
be prefixed correctly (LWIP_MDNS_OUTPACKET_SIZE, not just OUTPACKET_SIZE)
- patch 4: instead of repeating MDNS_INITIAL_PROBE_DELAY_MS and
MDNS_PROBE_DELAY_MS all over the place, could you hide this in two functions
(e.g. mdns_resp_restart() and mdns_resp_restart_initial())?
- patch 6: please improve the description of MDNS_MAX_STORED_PKTS and how it
affects memory consumption (e.g. what is this used for, so that people can
imagine how big this gets)
- patch 9: this 50ms offset seems kind of random?



    _______________________________________________________

Reply to this item at:

  <https://savannah.nongnu.org/patch/?9860>

_______________________________________________
  Message sent via Savannah
  https://savannah.nongnu.org/