[lwip-devel] [bug #46467] ip_frag() shouldn't modify pbuf in case of a retransmission

[Simon Goldschmidt]

Update of bug #46467 (project lwip):

                  Status:                    None => Need Info              

    _______________________________________________________

Follow-up Comment #6:

Zach, I don't understand the part where you say that tcp_output_segment()
adjusts the p->len based on the assumption that p->payload < tcphdr. For me
the seg->p->len/seg->p->tot_len modifications do work if p->payload > tcphdr.

Maybe this is due to 'len' being an u16_t? There might be compilers where
implicit integer promotion messes up the -= calculation that should take care
of fixing the pbuf length.

What compiler & platform are you seeing this on? Does it help to make 'len' a
(signed!) 'int' instead of 'u16_t'?

I know what tcp does here to the pbuf is rather hacky, but the problem is not
in ip_frag, it's in tcp_output_segment().

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?46467>

_______________________________________________
  Nachricht gesendet von/durch Savannah
  http://savannah.nongnu.org/