[lwip-devel] [patch #8869] ppp: fix broken ppp_netif_output

[Sylvain Rochet]

Follow-up Comment #1, patch #8869 (project lwip):

Hello Stephan,

+#if CCP_SUPPORT
 #if MPPE_SUPPORT

 #endif /* MPPE_SUPPORT */
+#endif /* CCP_SUPPORT */

That's not necessary, as per opt.h:

#ifndef MPPE_SUPPORT
#define MPPE_SUPPORT                    0
#endif
#if MPPE_SUPPORT
/* MPPE requires CCP support */
#undef CCP_SUPPORT
#define CCP_SUPPORT                     1
.....
#endif /* MPPE_SUPPORT */

MPPE_SUPPORT is false if not defined and force CCP_SUPPORT to be enabled if
MPPE_SUPPORT is enabled, therefore:

MPPE undef, CCP undef ->  MPPE 0, CCP 0
MPPE 1, CCP undef,    ->  MPPE 1, CCP 1
MPPE 1, CCP 0,        ->  MPPE 1, CCP 1
MPPE undef, CCP 1     ->  MPPE 0, CCP 1

The case where CCP_SUPPORT is not enabled but MPPE_SUPPORT is enabled isn't
possible.


-  if (pcb->ccp_is_up) {
+  if (pcb->ccp_is_up && pcb->ccp_transmit_method != 0) {

I don't think that's the proper fix, if CCP failed to establish,
pcb->ccp_is_up *MUST* be false,
if that's not the case, this is a bug, and this is this bug which must be
fixed.

Did you reach a case where pcb->ccp_is_up is true but pcb->ccp_transmit_method
isn't set to an available compressor (we only support MPPE so it should only
be 0 or MPPE) ?


Best,
Sylvain

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?8869>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/