[lwip-devel] [bug #46467] ip_frag() shouldn't modify pbuf in case of a retransmission

[Zach Smith]

URL:
  <http://savannah.nongnu.org/bugs/?46467>

                 Summary: ip_frag() shouldn't modify pbuf in case of a
retransmission
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: zsmith
            Submitted on: Tue 17 Nov 2015 09:29:56 PM GMT
                Category: IPv4
                Severity: 3 - Normal
              Item Group: Faulty Behaviour
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: 
            lwIP version: git head

    _______________________________________________________

Details:

The ip_frag() function modifies the pbuf. This is a problem because the pbuf
might be referenced again by TCP if unacked and a retry is needed.

I have attached a patch to ip_frag() that restores the pbuf before exiting
that seems to work for us.



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Tue 17 Nov 2015 09:29:56 PM GMT  Name: ip_frag_no_modify_p.patch  Size:
3kB   By: zsmith

<http://savannah.nongnu.org/bugs/download.php?file_id=35483>

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?46467>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/