[lwip-devel] [bug #46365] tcp_accept_null() should call tcp_abort()

[Valery Ushakov]

URL:
  <http://savannah.nongnu.org/bugs/?46365>

                 Summary: tcp_accept_null() should call tcp_abort()
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: uwe
            Submitted on: Mon 02 Nov 2015 02:30:52 PM GMT
                Category: TCP
                Severity: 3 - Normal
              Item Group: Faulty Behaviour
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: 
            lwIP version: git head

    _______________________________________________________

Details:

>From code inspection - shouldn't tcp_accept_null() call tcp_abort()?

The caller, tcp_process(), calls the accept callback like this

        /* Call the accept function. */
        TCP_EVENT_ACCEPT(pcb, ERR_OK, err);
        if (err != ERR_OK) {
          /* If the accept function returns with an error, we abort
           * the connection. */
          /* Already aborted? */
          if (err != ERR_ABRT) {
            tcp_abort(pcb);
          }
          return ERR_ABRT;
        }

Since tcp_accept_null() just returns ERR_ABRT, the caller will _not_ call it.




    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?46365>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/