[lwip-devel] [bug #45029] Several macros use ip6_2_ip() without supplying a storage address

[Ivan Delamer]

URL:
  <http://savannah.nongnu.org/bugs/?45029>

                 Summary: Several macros use ip6_2_ip() without supplying a
storage address
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: idelamer
            Submitted on: Tue 05 May 2015 12:16:38 PM MDT
                Category: IPv6
                Severity: 3 - Normal
              Item Group: Faulty Behaviour
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: 1.5.0
            lwIP version: git head

    _______________________________________________________

Details:

With the new ip_addr_t with type field, there are times where we must convert
a version-specific address to a generic address.

e.g. netconn_bind_ip6() macro

None of these macros are using ip6_2_ip() correctly.

Possible fixes:
1) add a storage address parameter to the macros
2) remove the macros and force the user to supply a ip_addr_t parameter

Recommended fix: #2. Since the user will have to supply a ip_addr_t in either
case, what's the point of keeping these macros?

I had originally added them when we didn't have the new ip_addr_t. I think
they are obsolete now.




    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?45029>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/