[lwip-devel] [bug #45022] Missing declaration for FD_SET_VAL()

[Edgar Bonet]

URL:
  <http://savannah.nongnu.org/bugs/?45022>

                 Summary: Missing declaration for FD_SET_VAL()
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: ebonet
            Submitted on: mar. 05 mai 2015 12:01:45 GMT
                Category: sockets/netconn
                Severity: 3 - Normal
              Item Group: Compiler Warning
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: 
            lwIP version: git head

    _______________________________________________________

Details:

Compiling simhost, from the Unix port, fails with the following
(slightly edited) error message:

    lwip/src/api/sockets.c:1159:7: In function ‘lwip_selscan’:
    error: implicit declaration of function ‘FD_SET_VAL’

FD_SET_VAL is a macro normally defined in
lwip/src/include/lwip/sockets.h, but its definition is conditioned
roughly as follows:

    #ifndef FD_SET
    #  define FD_SET(n, p) ...
    #  define FD_SET_VAL(n, p) ...
    ...
    #endif

which carries the assumption that defined(FD_SET) implies
defined(FD_SET_VAL). However, on the Unix port, FD_SET() is defined by
system headers (included via lwip/src/include/lwip/arch.h and
lwip-contrib/ports/unix/include/arch/cc.h), but FD_SET_VAL(), which
appears to be non-standard, is not.

The attached patch fixes this issue by providing an alternative
definition of FD_SET_VAL() when defined(FD_SET) && !defined(FD_SET_VAL).



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: mar. 05 mai 2015 12:01:45 GMT  Name:
0001-In-lwip-sockets.h-do-not-assume-defined-FD_SET-impli.patch  Size: 796 o  
By: ebonet

<http://savannah.nongnu.org/bugs/download.php?file_id=33920>

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?45022>

_______________________________________________
  Message posté via/par Savannah
  http://savannah.nongnu.org/