[lwip-devel] [bug #44565] PPPOS support in tcpip thread breaks SLIP

[Ivan Delamer]

URL:
  <http://savannah.nongnu.org/bugs/?44565>

                 Summary: PPPOS support in tcpip thread breaks SLIP
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: idelamer
            Submitted on: Tue 17 Mar 2015 04:54:46 PM MDT
                Category: PPP
                Severity: 3 - Normal
              Item Group: Faulty Behaviour
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: 
            lwIP version: git head

    _______________________________________________________

Details:

PPPOS uses the tcpip thread to process incoming packets. This code was added
to tcpip_thread():

#if PPPOS_SUPPORT
      /* FIXME: can be generalized to all point to point interfaces */
      if ((msg->msg.inp.netif->flags & NETIF_FLAG_BROADCAST) == 0
            && msg->msg.inp.netif->input) {
        msg->msg.inp.netif->input(msg->msg.inp.p, msg->msg.inp.netif);
      } else
#endif /* PPPOS_SUPPORT */

I use SLIP netif, where netif->input = tcpip_input;

So every time we get a slip packet it keeps putting it into the tcpip queue
forever.

I see how this works well for PPPOS. I guess we could add a condition  to the
IF statement:
   
   && (msg->msg.inp.netif->input != tcpip_input)

Cheers
Ivan





    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?44565>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/