[lwip-devel] [bug #43583] dhcp_recv() won't work on netifs with multiple hwaddrs

[Hugo Fiennes]

URL:
  <http://savannah.nongnu.org/bugs/?43583>

                 Summary: dhcp_recv() won't work on netifs with multiple
hwaddrs
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: hugof
            Submitted on: Wed 12 Nov 2014 01:29:05 AM GMT
                Category: DHCP
                Severity: 3 - Normal
              Item Group: Faulty Behaviour
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: 
            lwIP version: 1.4.1

    _______________________________________________________

Details:

...as the code will abort receive packet processing on the first mismatch,
whereas it should only abort if the chaddr is not ANY of the netif hwaddrs.

See below from dhcp_recv():

 /* iterate through hardware address and match against DHCP message */
  for (i = 0; i < netif->hwaddr_len; i++) {
    if (netif->hwaddr[i] != reply_msg->chaddr[i]) {
      LWIP_DEBUGF(DHCP_DEBUG | LWIP_DBG_TRACE | LWIP_DBG_LEVEL_WARNING,
        ("netif->hwaddr[%"U16_F"]==%02"X16_F" !=
reply_msg->chaddr[%"U16_F"]==%02"X16_F"\n",
        (u16_t)i, (u16_t)netif->hwaddr[i], (u16_t)i,
(u16_t)reply_msg->chaddr[i]));
      goto free_pbuf_and_return;
    }
  }




    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?43583>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/