[lwip-devel] [bug #39225] udp.c uses netif_matches_ip6_addr() incorrectly

[Valery Ushakov]

URL:
  <http://savannah.nongnu.org/bugs/?39225>

                 Summary: udp.c uses netif_matches_ip6_addr() incorrectly
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: uwe
            Submitted on: Tue 11 Jun 2013 12:02:05 AM GMT
                Category: UDP
                Severity: 3 - Normal
              Item Group: Faulty Behaviour
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: 
            lwIP version: git head

    _______________________________________________________

Details:

netif_matches_ip6_addr() returns slot index (can be 0) on match, -1 if no
match found.

udp_input() incorrectly uses that function:


  for_us = netif_matches_ip6_addr(inp, ip6_current_dest_addr());
  ...
  if (for_us) {
    ...


Later in udp.c the function is used correctly by udp_sendto_if_chksum().

The "matches" part of the name is confusing.  It suggests boolean return
value, so it's probably better to rename it to reflect that it returns an
index.




    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Tue 11 Jun 2013 12:02:05 AM GMT  Name: udp-netif-matches-ip6.diff  Size:
423B   By: uwe

<http://savannah.nongnu.org/bugs/download.php?file_id=28288>

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?39225>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/