[lwip-devel] [bug #33804] LWIP_IPV6_MLD #define missing from mld6.c

[Brad Giffel]

URL:
  <http://savannah.nongnu.org/bugs/?33804>

                 Summary: LWIP_IPV6_MLD #define missing from mld6.c
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: bgiffel
            Submitted on: Tue 19 Jul 2011 08:39:04 PM GMT
                Category: IPv6
                Severity: 3 - Normal
              Item Group: Compiler Warning
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: 
            lwIP version: CVS Head

    _______________________________________________________

Details:


If LWIP_IPV6_MLD is defined as 0 and LWIP_IPV6 is defined as 1, the mld6.c
file is compiled when it really shouldn't be.  Line 47 of mld6.c should be:

#if LWIP_IPV6_MLD && LWIP_IPV6  /* don't build if not configured for use in
lwipopts.h */


Note: technically not a 'Compiler Warning' but more of an actual compilation
failure but there was no Item Group for that.


Might suggest that opt.h validate macros like LWIP_IPV6_MLD and force them to
zero if LWIP_IPV6 is zero.  Then mld6.c can be conditionally compiled by only
checking LWIP_IPV6_MLD.  Which of course is probably a different ticket....





    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?33804>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/