[lwip-devel] [bug #26487] igmp_ip_output_if uses IP_HDRINCL at the wrong place

[Simon Goldschmidt]

URL:
  <http://savannah.nongnu.org/bugs/?26487>

                 Summary: igmp_ip_output_if uses IP_HDRINCL at the wrong
place
                 Project: lwIP - A Lightweight TCP/IP stack
            Submitted by: goldsimon
            Submitted on: Do 07 Mai 2009 18:09:09 GMT
                Category: IPv4
                Severity: 3 - Normal
              Item Group: Faulty Behaviour
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: 
            lwIP version: CVS Head

    _______________________________________________________

Details:

pbuf_header(p, IP_HLEN) is executed even if IP_HDRINCL is given, which
results in a wrong payload.

The reason for posting this here and not fixing directly is I'd rather solve
this more cleanly: I think we should provide a function in ip.c to include IP
options in an IP header (which is what igmp_ip_output_if needs) instead of
duplicating the ip_output_if code in igmp_ip_output_if.

This would both make the code smaller and prevent bugs getting fixed in one
place while staying in the other. Also, the current igmp_ip_output_if code
omits stats, snmp and loopback!

I'd add the function ip_output_if_options() that adds 2 arguments (void
*options, int optlen) to ip_output_if().




    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?26487>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.nongnu.org/