lwip-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lwip-devel] [bug #25608] Unable to use NO_SYS=1 and SYS_LIGHTWEIGHT_PRO


From: Bill Auerbach
Subject: [lwip-devel] [bug #25608] Unable to use NO_SYS=1 and SYS_LIGHTWEIGHT_PROT=1
Date: Tue, 03 Mar 2009 17:07:01 +0000
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.6) Gecko/2009011913 Firefox/3.0.6

Follow-up Comment #11, bug #25608 (project lwip):

Kieran, if protection isn't NO_SYS dependent, doesn't it make sense to move
the protection #defines outside of the #if NO_SYS #else #endif group
entirely?

At the top of sys.h, I don't understand why not add #include "sys_arch.h" for
both cases of NO_SYS.  The system requirements in sys.h should bring in any
architecture requirements or overrides for both cases.  sys_arch.h should take
care of its NO_SYS business.

BTW, my sys_arch.h does have NO_SYS=1 and NO_SYS=0 sections for the time that
I might have a NO_SYS=0 port for the same architecture.  To be complete, I
think a port which defines an architecture in sys_arch should allow for both
NO_SYS=0 and NO_SYS=1 cases.  In fact, I think the less the core files depend
on NO_SYS the better.

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?25608>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/





reply via email to

[Prev in Thread] Current Thread [Next in Thread]