[lwip-devel] [patch #6760] Ping calculates incorrect checksum

[Robert Sprowson]

Follow-up Comment #6, patch #6760 (project lwip):

Or perhaps a slight shuffle so the len parameter becomes the length of the
data to append:

 for (0 to len)
 {
 }
 checksum(sizeof(icmp) + len)

so that callers don't need to know how big an ICMP header is, which did
strike me on first reading as a bit clumsy.

There's still an extra run time calculation, but I can't see a way to skip
that and still have cleaner code.

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?6760>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/