Re: [lwip-devel] #if can't use enum vaule ETHARP_STATE_EMPTY

[Kieran Mansley]

On Fri, 2008-02-15 at 15:08 +0000, Jonathan Larmour wrote:
> Bill Auerbach wrote:
> >Kieran wrote:
> >> Anyone know why we couldn't just do:
> >>
> >> enum etharp_state {
> >> /* "ETHARP_STATE_EMPTY must be 0 to ensure correct initialization
> >> value!" */
> >>  ETHARP_STATE_EMPTY = 0,
> >>  ETHARP_STATE_PENDING,
> >>  ETHARP_STATE_STABLE
> >> };
> >>
> >> i.e. force it to be zero?  I'm never sure if such things are supported
> >> on all compilers.
> > 
> > This is standard enum syntax and will work everywhere.
> 
> Indeed, I was about to say the same :). It's standard C.
> 
> Kieran, there has been this and a bunch of small but non-critical changes
> that people have been reporting (e.g. warning fixes). I'm not sure what the
> criteria is for checking in changes at the moment. Is it ok?

For small, non-functional changes such as this it should be OK to check
in.  I'm hoping to do a second pass of any open bugs to see if there's
anything new that needs resolving before the final release of 1.3.0 - I
just need the time!

Kieran