[lwip-devel] [task #6969] Review usage of conn->err in netconn layer

[Jonathan Larmour]

Follow-up Comment #24, task #6969 (project lwip):

> So, perhaps can you give your list about what is "fatal", and
> what is not?

Well, that was my point :-) ... sometimes the same sort of error may be fatal
or not.

For example, memory errors would be non-fatal - fine. For example one I have
in my driver is if someone tries to send a packet where the pbuf chain is more
than the driver can cope with. That packet can never ever be sent as it is,
but ERR_MEM doesn't seem right because retrying will never help. But at the
same time returning ERR_IF marks the whole connection as dead (which is what
happens in current code until this task is complete) which doesn't seem right
either because other packets would work. What I might like is something like a
non-fatal ERR_IF.
 
But I was only suggesting the bitmask as an idea, that's all. And to be
honest, the problem above isn't such a big problem. You don't have to agree,
in which case what you had in IRC seemed okay. I guess what really matters is
consistency and making sure everyone knows what errors really mean.

> About the bitmask, the problem could be with err_to_errno_table
> in sockets.c. But we could mask it (bit 6) I think.

Yes, that's also what I was thinking of.



    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/task/?6969>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/