lwip-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [lwip-devel] Re: [patch #6253] Added csum to struct pbuf.


From: address@hidden
Subject: Re: [lwip-devel] Re: [patch #6253] Added csum to struct pbuf.
Date: Thu, 01 Nov 2007 14:05:08 +0100
User-agent: Thunderbird 2.0.0.6 (Windows/20070728)

When talking about bugs/tasks/patches that have an item in the bug tracker, could you please answer using the bug-tracker at https://savannah.nongnu.org/patch/?6253 so all thoughts and answers for this item are easily found in one place.

Simon

Andrey Volkov schrieb:
Frédéric Bernon wrote:
Follow-up Comment #2, patch #6253 (project lwip):

Is HWD_SUPPORT_CSUM will be appropriate?

Andrey
CHECKSUM_HARDWARE_SUPPORT (to be in the same spirit than other
CHECKSUM_xxx) ?

Ok, accepted.

Do you have read "task #6849 : Test how checksum on copy could be
integrated into the stack" (https://savannah.nongnu.org/task/?6849) ?


Yes, but I introduce this field mainly for next purposes:
 1) speed up reassembly of incoming ip packets. In reassembly case,
    ip payload csum of each fragment should be stored somewhere.
    (IMHO, pbuf is very appropriate for it).
 2) Hardware usually could calculate ip payload/headers checksum,
    but not tcp/udp pseudo checksum, hence ip csum should be stored.
    Also, I dislike to mix different levels of stack in one piece
    of code. I.e. if I've ip checksum in eth driver, I could undef
    CHECKSUM_CHECK_IP, but not CHECKSUM_CHECK_TCP/CHECKSUM_CHECK_UDP,
    since I don't know it in driver level.
And,
 3) In my hwd. driver, I don't 'memcpy' incoming packets, DMA do it
    directly to pbuf.

--
Regards
Andrey Volkov



_______________________________________________
lwip-devel mailing list
address@hidden
http://lists.nongnu.org/mailman/listinfo/lwip-devel







reply via email to

[Prev in Thread] Current Thread [Next in Thread]