lwip-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[lwip-devel] [patch #6250] MSG_MORE flag for send


From: Simon Goldschmidt
Subject: [lwip-devel] [patch #6250] MSG_MORE flag for send
Date: Tue, 30 Oct 2007 10:34:50 +0000
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.8.1.8) Gecko/20071008 Firefox/2.0.0.8

Follow-up Comment #7, patch #6250 (project lwip):

> #if ((!defined(MSG_PEEK)) && (!defined(MSG_WAITALL)) &&
> (!defined(MSG_OOB)) && (!defined(MSG_DONTWAIT)))

I think that's a bad idea. That way, you won't even get a warning when
another header defines these constants to a different value - but the software
doesn't work!

Better
a) to leave it like it is and let the user sort it out or
b) rename the constants (which isn't really portable...)

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?6250>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.nongnu.org/





reply via email to

[Prev in Thread] Current Thread [Next in Thread]