[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[lwip-devel] [patch #6250] MSG_MORE flag for send
From: |
Frédéric Bernon |
Subject: |
[lwip-devel] [patch #6250] MSG_MORE flag for send |
Date: |
Mon, 29 Oct 2007 20:56:50 +0000 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 6.0; fr; rv:1.8.1.8) Gecko/20071008 Firefox/2.0.0.8 |
Follow-up Comment #4, patch #6250 (project lwip):
Yes, last patch seems good, except some minor things:
- I don't understand your changes in sockets.h
- I think it's better to use NETCONN_COPY in sockets.c (and not directly
API_FLAG_COPY)
- some comments don't seem to be explicit enought : "@param apiflags 2 if PSH
flag should be set on last segment, 1 if data must be copied, 0 if data is
non-volatile and can be referenced"
Last, I think we could find some better names for API_FLAG_xxx and for
apiflags (but, I don't have an idea now).
_______________________________________________________
Reply to this item at:
<http://savannah.nongnu.org/patch/?6250>
_______________________________________________
Message posté via/par Savannah
http://savannah.nongnu.org/
- [lwip-devel] [patch #6250] MSG_MORE flag for send, Marc Chaland, 2007/10/29
- [lwip-devel] [patch #6250] MSG_MORE flag for send, Frédéric Bernon, 2007/10/29
- [lwip-devel] [patch #6250] MSG_MORE flag for send, Jonathan Larmour, 2007/10/29
- [lwip-devel] [patch #6250] MSG_MORE flag for send, Marc Chaland, 2007/10/29
- [lwip-devel] [patch #6250] MSG_MORE flag for send,
Frédéric Bernon <=
- [lwip-devel] [patch #6250] MSG_MORE flag for send, Marc Chaland, 2007/10/30
- [lwip-devel] [patch #6250] MSG_MORE flag for send, Frédéric Bernon, 2007/10/30
- [lwip-devel] [patch #6250] MSG_MORE flag for send, Simon Goldschmidt, 2007/10/30
- [lwip-devel] [patch #6250] MSG_MORE flag for send, Frédéric Bernon, 2007/10/30
- [lwip-devel] [patch #6250] MSG_MORE flag for send, Marc Chaland, 2007/10/30
- [lwip-devel] [patch #6250] MSG_MORE flag for send, Frédéric Bernon, 2007/10/30
- [lwip-devel] [patch #6250] MSG_MORE flag for send, Frédéric Bernon, 2007/10/30
- [lwip-devel] [patch #6250] MSG_MORE flag for send, Jonathan Larmour, 2007/10/30
- [lwip-devel] [patch #6250] MSG_MORE flag for send, Jonathan Larmour, 2007/10/30
- [lwip-devel] [patch #6250] MSG_MORE flag for send, Frédéric Bernon, 2007/10/30