[lwip-devel] [task #7142] Sanity check user-configurable values

[Frédéric Bernon]

Follow-up Comment #30, task #7142 (project lwip):

I would like to know if - with current code - it's wrong to suppose that
slipif and ppp need NO_SYS=0? I ask this because I see they use
sys_thread_new.

For slipif, I think it's not a problem (the processing in slipif_loop can be
done in the "single-thread" model). We could perhaps add #if !NO_SYS/#endif
around slipif_loop() just to signal this function is used when you got an OS.

But, for PPP, it seems that pppMain do lot of job in "blocking" while. More,
there is some calls to tcpip_callback, timeout, etc... So, I suppose we should
add some others sanity check for that:

#if (PPP_SUPPORT && (NO_SYS==1))
  #error "If you want to use PPP, you have to define NO_SYS=0 in your
lwipopts.h"
#endif


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/task/?7142>

_______________________________________________
  Message posté via/par Savannah
  http://savannah.nongnu.org/