Re: RE : [lwip-devel] Last changes by Marc

[Jonathan Larmour]

Frédéric BERNON wrote:
> > > - "tcpip.c / ETHARP_TCPIP_INPUT / ETHARP_TCPIP_ETHINPUT": No problem,
> > > but, to be honest, I'm in flavor to remove ETHARP_TCPIP_INPUT & 
> > > ETHARP_TCPIP_ETHINPUT option, and to only support "ETHINPUT" case. It 
> > > will simplify the code, and is the only way to have no concurrent access 
> > > in ARP module. No objects to change that?
>
>
> > That seems fine to me. Worth doing for 1.3 I think since we're breaking old 
> > ports as it is, so no reason to hold back here (and cause more breakage for 
> > 1.4).
>
>
> About this last point, I have attached a ETHARP_TCPIP.txt patch file about the 
> proposed change.
>
> Is there any objects about it?

I had thought you had meant make it only the ETHARP_TCPIP_ETHINPUT option, 
rather than make it no option at all. Not everyone uses ethernet, and 
there may be other routes for drivers to introduce packets to the system 
(e.g. via their own tcpip_callback calls, like PPP does), so it should 
still be an option I think. Not least if anyone was using only PPP, not 
ethernet.

By the way, in the proposed patch, it also seemed like you removed the 
function calls within the PPPOE support in ethernetif.c (pppoe_*_input).

Jifl
--
eCosCentric Limited      http://www.eCosCentric.com/     The eCos experts
Barnwell House, Barnwell Drive, Cambridge, UK.       Tel: +44 1223 245571
Registered in England and Wales: Reg No 4422071.
------["The best things in life aren't things."]------      Opinions==mine